Merged
Conversation
vihangm
force-pushed
the
vihang/coverage_fix
branch
2 times, most recently
from
54c2f4e to
c79dc16
Compare
Signed-off-by: Vihang Mehta <vihang@gimletlabs.ai>
vihangm
force-pushed
the
vihang/coverage_fix
branch
from
c79dc16 to
05b0c65
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2182 +/- ##
==========================================
- Coverage 44.63% 44.52% -0.12%
==========================================
Files 1196 1207 +11
Lines 86026 86724 +698
Branches 25009 25295 +286
==========================================
+ Hits 38402 38612 +210
- Misses 31780 32209 +429
- Partials 15844 15903 +59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vihangm
force-pushed
the
vihang/coverage_fix
branch
from
05b0c65 to
caf8fb0
Compare
vihangm
changed the title
ddelnano
approved these changes
Apr 24, 2025
ddelnano
approved these changes
Apr 24, 2025
aimichelle
approved these changes
Apr 24, 2025
ddelnano
pushed a commit
to ddelnano/pixie
that referenced
this pull request
Aug 6, 2025
Summary: Coverage runs were using remote_download_output=all because thing didn't work with Bazel Build Without the Bytes. It seems that after bazelbuild/bazel#4685 this should work, so this change attempts to shift coverage runs to use BWOB to avoid downloading all outputs. This also fixes some warnings and errors we ran into with the ubuntu 24.04 upgrade which causes lcov 2 to be installed. Relevant Issues: N/A Type of change: /kind bug Test Plan: Will check github actions on this PR. Signed-off-by: Vihang Mehta <vihang@px.dev> GitOrigin-RevId: 9ec7a67
ddelnano
pushed a commit
to k8sstormcenter/pixie
that referenced
this pull request
Feb 25, 2026
Summary: Coverage runs were using remote_download_output=all because thing didn't work with Bazel Build Without the Bytes. It seems that after bazelbuild/bazel#4685 this should work, so this change attempts to shift coverage runs to use BWOB to avoid downloading all outputs. This also fixes some warnings and errors we ran into with the ubuntu 24.04 upgrade which causes lcov 2 to be installed. Relevant Issues: N/A Type of change: /kind bug Test Plan: Will check github actions on this PR. Signed-off-by: Vihang Mehta <vihang@px.dev>
ddelnano
pushed a commit
to k8sstormcenter/pixie
that referenced
this pull request
Feb 25, 2026
Summary: Coverage runs were using remote_download_output=all because thing didn't work with Bazel Build Without the Bytes. It seems that after bazelbuild/bazel#4685 this should work, so this change attempts to shift coverage runs to use BWOB to avoid downloading all outputs. This also fixes some warnings and errors we ran into with the ubuntu 24.04 upgrade which causes lcov 2 to be installed. Relevant Issues: N/A Type of change: /kind bug Test Plan: Will check github actions on this PR. Signed-off-by: Vihang Mehta <vihang@px.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Coverage runs were using remote_download_output=all because thing didn't work with Bazel Build Without the Bytes. It seems that after bazelbuild/bazel#4685 this should work, so this change attempts to shift coverage runs to use BWOB to avoid downloading all outputs.
This also fixes some warnings and errors we ran into with the ubuntu 24.04 upgrade which causes lcov 2 to be installed.
Relevant Issues: N/A
Type of change: /kind bug
Test Plan: Will check github actions on this PR.